This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
Fix a bug, don't trigger onMoreAsked when adapter has no data or visi… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bleItemCount equal totalItemCount
|
@doubleDragon Hi! Unfortunately if you do it this way there will be an edge case on initial start of view where you set the adapter with small number of items (not enough to fill in the screen). In this case I'd like to fetch more, but if you handle scroll state and data your way it won't call onMoreAsked. But for the adapter case that is not set - feel free to create a PR for that, I'll merge it. Let me know what you think |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i found two problem when using SuperRecyclerView.
First, there is no necessary to trigger api{#link onMoreAsked()} when adapter has no data or visibleItemCount equal totalItemCount, i have fixed in my fork project from you repo.
Second, i suggest you invoke api{#link processOnMore()} when scroll state equal RecyclerView.SCROLL_STATE_IDLE, because sometimes api{#link onMoreAsked()} always trigger loadingMore after scroll down.My suggest code like below:
@OverRide
public void onScrollStateChanged(RecyclerView recyclerView, int newState) {
super.onScrollStateChanged(recyclerView, newState);
if(newState == RecyclerView.SCROLL_STATE_IDLE) {
processOnMore();
}
}